.Net: Return result of the function executed before termination for streaming API #6428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
SergeyMenshykh
requested review from
dmytrostruk,
RogerBarreto and
markwallace-microsoft
dmytrostruk
approved these changes
May 28, 2024
There was a problem hiding this comment.
@SergeyMenshykh Just for the context, I decided to not return function result in streaming termination scenario on purpose, because I wasn't sure if returning entire result as one chunk is a right approach, and function result is still accessible via ChatHistory input parameter, when using IChatCompletionService.
Based on created issue, it looks like this is expected behavior by developers, so it's probably worth to add it. Thanks for adding this!
RogerBarreto
approved these changes
May 29, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…treaming API (microsoft#6428) ### Motivation, Context and Description Fixes: microsoft#6404 Today, the SK chat completion streaming API does not return the result of a function executed before termination, whereas the non-streaming version does return the result. This PR resolves this issue by returning the result of a function executed before termination was requested. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
Fixes: #6404
Today, the SK chat completion streaming API does not return the result of a function executed before termination, whereas the non-streaming version does return the result. This PR resolves this issue by returning the result of a function executed before termination was requested.
Contribution Checklist